Update vscode-languageserver-protocol version #12012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msujew
approved these changes
Dec 20, 2022
There was a problem hiding this comment.
LGTM 👍
@vince-fugnitto Should we include this in the upcoming release or wait?
msujew
added
dependencies
@msujew I would maybe wait, but what do you think? |
|
I don't really have an opinion on this, but also no idea how urgent this is from @tortmayr's perspective. |
|
@vince-fugnitto @msujew It's not urgent at all, no need to squeeze this into the upcoming release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Updates the shared
vscode-language-server-protocoldependency to the latest version. The previous version (3.15.x) is quite old and pulls in an outdated version ofvscode-jsonrpc(5.x). This can cause conflicts with adopters that want to use a more recent version.Previously this update was blocked due to an incompatibility with
vscode-ws-jsonrpc(see #8868). However, after the recent RPC communication refactoring we no longer usevscode-ws-jsonrpcand can update without issues.How to test
There is nothing to explicitly test. Everything should work as before.
Review checklist
Reminder for reviewers